Your Legal Resource

Binary Recordio

Makes recordio only record I/O if RECORDIO is in the environment.


I like the idea, but shouldn't you make recordio not record if something

like NORECORDIO is in the environment, as opposed to making it record only

if RECORDIO is in the environment? I mean, when people use recordio, they

expect it to record io.

------------------------------------------------------------------------------------------------

diff -c dist/ucspi-tcp-0.84/Makefile local/ucspi-tcp-0.84/Makefile

*** dist/ucspi-tcp-0.84/Makefile Wed Nov 11 21:32:01 1998

--- local/ucspi-tcp-0.84/Makefile Wed Jul 07 14:16:54 1999

***************

*** 451,459 ****

  tcpcat mconnect mconnect-io fixcr addcr delcr argv0 recordio rts

  recordio:

! load recordio.o strerr.a substdio.a error.a str.a fs.a fd.a sig.a

! ./load recordio strerr.a substdio.a error.a str.a fs.a

! fd.a sig.a

  recordio.0:

  recordio.1

--- 451,459 ----

  tcpcat mconnect mconnect-io fixcr addcr delcr argv0 recordio rts

  recordio:

! load recordio.o strerr.a substdio.a error.a env.a str.a fs.a fd.a sig.a

! ./load recordio strerr.a substdio.a error.a env.a str.a fs.a

! fd.a sig.a

  recordio.0:

  recordio.1

diff -c dist/ucspi-tcp-0.84/recordio.c local/ucspi-tcp-0.84/recordio.c

*** dist/ucspi-tcp-0.84/recordio.c Wed Nov 11 21:32:01 1998

--- local/ucspi-tcp-0.84/recordio.c Wed Jul 07 14:03:59 1999

***************

*** 7,12 ****

--- 7,13 ----

  #include "exit.h"

  #include "fmt.h"

  #include "select.h"

+ #include "env.h"

  #define FATAL "recordio: fatal: "

***************

*** 138,143 ****

--- 139,146 ----

    if (argc < 2)

      strerr_die1x(100,"recordio: usage: recordio program [ arg ... ]");

+ if (env_get("RECORDIO")) {

+

    if (pipe(piin) == -1)

      strerr_die2sys(111,FATAL,"unable to create pipe: ");

    if (pipe(piout) == -1)

***************

*** 159,164 ****

--- 162,169 ----

      strerr_die2sys(111,FATAL,"unable to move descriptors: ");

    if (fd_move(1,piout[1]) == -1)

      strerr_die2sys(111,FATAL,"unable to move descriptors: ");

+

+ }

    execvp(argv[1],argv + 1);

    strerr_die4sys(111,FATAL,"unable to run ",argv[1],": ");


Image of Binary Recordio